bth/um-mode
Watch
1
Fork
You've already forked um-mode
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

um-tag-insert-dwim : dont choke before dired is loaded

Browse source
This commit is contained in:
bth 2025-12-15 20:04:22 -08:00
commit c823ea1930
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
elisp/um.el
View file

@ -198,20 +198,21 @@ Assumes the files of interest are returned by `um-journal-path'.
(interactive) (interactive)
(let* ( (let* (
(tag (completing-read "tag: " um-tags-history nil nil nil 'um-tags-history)) (tag (completing-read "tag: " um-tags-history nil nil nil 'um-tags-history))
(marks (dired-get-marked-files)) (marks (if (eq major-mode 'dired-mode) (dired-get-marked-files) nil))
;; NOTE: 'existing-filename would be better to avoid bogus strings, but ;; NOTE: 'existing-filename would be better to avoid bogus strings, but
;; in view-mode when in another project, we can't verify it exists yet: ;; in view-mode when in another project, we can't verify it exists yet:
(fap (thing-at-point 'filename)) (fap (thing-at-point 'filename))
(files (cond (files (cond
((and (region-active-p) (not (eq major-mode 'dired-mode))) ((and (region-active-p) (not (eq major-mode 'dired-mode)))
(string-split (buffer-substring (region-beginning) (region-end)))) (string-split (buffer-substring (region-beginning) (region-end))))
((and (eq major-mode 'dired-mode) marks) marks) (marks marks)
(fap (list fap)) (fap (list fap))
)) ))
;; save-excursion is not working below, why? ;; save-excursion is not working below, why?
(buf (current-buffer))) (buf (current-buffer)))
(if files (progn (dolist (f files) (if files (progn (dolist (f files)
;; TODO: this should use the fallback logic:
(find-file (expand-file-name f (um-journal-path))) (find-file (expand-file-name f (um-journal-path)))
(um-tag-insert tag) (um-tag-insert tag)
) )