bth/um
Watch
1
Fork
You've already forked um
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cat : fix previous : the make allocation was all wrong, use strings.Builder in place of strings.Join

Browse source
This commit is contained in:
bth 2026-01-21 13:06:18 -08:00
commit cade3efe6f
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
cat/cat.go
View file

@ -30,6 +30,7 @@ func initOpts() options {
} }
func cat(files []string) (string, error) { func cat(files []string) (string, error) {
sb := strings.Builder{}
var total int64 var total int64
for _, f := range files { for _, f := range files {
stat, err := os.Stat(f) stat, err := os.Stat(f)
@ -40,15 +41,16 @@ func cat(files []string) (string, error) {
total += stat.Size() total += stat.Size()
} }
} }
ff := make([]string, 0, total) sb.Grow(int(total))
for _, f := range files { for _, f := range files {
dat, err := os.ReadFile(f) dat, err := os.ReadFile(f)
if err != nil { if err != nil {
return "", fmt.Errorf("error opening file: %w", err) return "", fmt.Errorf("error opening file: %w", err)
} }
ff = append(ff, string(dat)) sb.WriteString(fmt.Sprintf("%s%s", dat, SEPARATOR))
} }
return strings.Join(ff, SEPARATOR), nil return strings.TrimSuffix(sb.String(), SEPARATOR), nil
} }
func Cat(args []string) { func Cat(args []string) {